Foreign key ux mode annotation support #986
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RFSH
reviewed
Aug 23, 2023
RFSH
reviewed
Aug 23, 2023
RFSH
approved these changes
Aug 23, 2023
There was a problem hiding this comment.
Everything looks good and ready to be merged. I just asked for a very small code change.
You should also document this property on the column-directive standalone doc.
jrchudy
added
the
annotation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
inputDisplayModeproperty to foreign key pseudo columns. This is added for 3 annotations currently as the propertyselector_ux_mode. By default, this property is set topopupto use the more robust recordset modal popup that includes sorting, filtering, and updating page size.For defining
inputDisplayMode, it will look forselector_ux_modein the following order:popupThese changes go alongside the changes in chaise to add a another input field for the
dropdowncase.